Search before asking
Motivation
While working on #991, I noticed that EscapeHexCellWriteHandler has no dedicated tests, and the pattern-scanning code has some edges worth tidying.
Solution
I will do it in 2 PR.
1. Testing
2. Refactoring/cleanup
Hold off reviewing this section until 1. is merged - the tests need to pin current behaviour before
anything underneath them moves.
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?
Search before asking
Motivation
While working on #991, I noticed that
EscapeHexCellWriteHandlerhas no dedicated tests, and the pattern-scanning code has some edges worth tidying.Solution
I will do it in 2 PR.
1. Testing
and non-applicable inputs (wrong cell data type, null values) are safely ignored.
escaped value survives being read back.
2. Refactoring/cleanup
written out twice across two methods.
logic is easier to verify by inspection.
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?