Migrate github importer to importer improver model#642
Merged
Conversation
pombredanne
requested changes
Mar 10, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! I have a few nits for your consideration
TG1999
force-pushed
the
migration/github
branch
from
March 16, 2022 08:47
5b6bb67 to
104db79
Compare
pombredanne
approved these changes
Mar 18, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Here are some nits for your review... Please fix the ones you think are essential and create issues for the ones that can wait and merge at you convenience.
TG1999
changed the title
TG1999
force-pushed
the
migration/github
branch
from
March 23, 2022 12:41
bcc79fc to
d1bc81c
Compare
pombredanne
reviewed
Mar 24, 2022
pombredanne
reviewed
Mar 24, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Here are a few nits for your consisderation
Migrate github importer to importer-improver model Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
migration/github
branch
from
March 25, 2022 08:15
d1bc81c to
b6aad46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com