Skip to content

Commit bcc79fc

Browse files
committed
address review comments
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent d574079 commit bcc79fc

5 files changed

Lines changed: 785 additions & 29 deletions

File tree

vulnerabilities/package_managers_2.py

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -190,30 +190,24 @@ def fetch(self, pkg) -> None:
190190
@staticmethod
191191
def nuget_url(pkg_name: str) -> str:
192192
pkg_name = pkg_name.lower().strip()
193-
base_url = "https://api.nuget.org/v3/registration5-semver1/{}/index.json"
194-
return base_url.format(pkg_name)
193+
base_url = f"https://api.nuget.org/v3/registration5-semver1/{pkg_name}/index.json"
194+
return base_url
195195

196196
@staticmethod
197197
def extract_versions(resp: dict) -> Set[LegacyVersion]:
198198
all_versions = set()
199-
try:
200-
for entry_group in resp["items"] or []:
201-
for entry in entry_group["items"] or []:
202-
catalog_entry = entry["catalogEntry"] or {}
203-
version = catalog_entry.get("version")
204-
release_date = dateparser.parse(catalog_entry.get("published"))
205-
if version and release_date:
206-
all_versions.add(
207-
LegacyVersion(
208-
value=version,
209-
release_date=release_date,
210-
)
199+
for entry_group in resp["items"] or []:
200+
for entry in entry_group["items"] or []:
201+
catalog_entry = entry["catalogEntry"] or {}
202+
version = catalog_entry.get("version")
203+
release_date = dateparser.parse(catalog_entry.get("published"))
204+
if version and release_date:
205+
all_versions.add(
206+
LegacyVersion(
207+
value=version,
208+
release_date=release_date,
211209
)
212-
# FIXME: json response for YamlDotNet.Signed triggers this exception.
213-
# Some packages with many versions give a response of a list of endpoints.
214-
# In such cases rather, we should collect data from those endpoints.
215-
except KeyError:
216-
LOGGER.error(f"Failed to parse nuget response for {resp!r}")
210+
)
217211

218212
return all_versions
219213

0 commit comments

Comments
 (0)