[7.1 Backport] -- Media: Add timeout and size guardrails to client-side GIF to video conversion

[adamsilverstein]

Backports #80379 (merged as 8852382) to the wp/7.1 branch. The automated cherry-pick failed with conflicts; see #80379 (comment).

Stacked on #80421 (the #79955 backport), matching the order the originals merged in trunk. Once #80421 merges into wp/7.1, this PR's diff reduces to just the #80379 changes.

Why

Fixes #80376 for WordPress 7.1: adds a conversion timeout and a pixel budget (width x height x frames) to client-side GIF-to-video conversion so oversized GIFs skip conversion instead of wedging the upload queue, and makes cancelItem's worker cancellation calls best-effort so a crashed or busy worker cannot block cancellation.

Conflict resolution

The automated cherry-pick's conflicts were caused by wp/7.1 missing #79955, which on trunk changed the same cancelItem lines. With #80421 applied first, the #80379 cherry-pick applies with no conflicts at all.

Verification

Every source file at the stack tip is byte-identical to current trunk (git diff origin/trunk is empty across packages/upload-media/src, packages/video-conversion/src, packages/worker-threads/src, and the e2e spec), and the changed-file list matches the original PR exactly. All upload-media, video-conversion, and worker-threads unit tests pass (410 tests).

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Size Change: +535 B (+0.01%)

Total Size: 7.73 MB

📦 View Changed

Filename	Size	Change
build/modules/video-conversion/worker.min.js	83.7 kB	+223 B (+0.27%)
build/scripts/upload-media/index.min.js	15.5 kB	+312 B (+2.05%)

_{compressed-size-action}

[github-actions]

Flaky tests detected in 6368d85.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29651846081
📝 Reported issues:

• [Flaky Test] should update the HTML only for the latest navigation #78835 in /test/e2e/specs/interactivity/router-navigate.spec.ts

[t-hamano]

In my understanding, it seems easier to backport #80421 first rather than backporting this PR. See #80421 (comment)

[adamsilverstein]

In my understanding, it seems easier to backport #80421 first rather than backporting this PR. See #80421 (comment)

Good point! Done.

[andrewserong]

Looks good to land after the other PR to me!

[andrewserong]

Not sure if this is a rebase or merge nit, but this adds an extra ### Bug Fixes heading (we already have one below). Is it worth doing a pass to make sure these are in the right order / no duplicate headings, in case that helps subsequent backports?

[adamsilverstein]

will fix.

[adamsilverstein]

Fixed in 02c163e - merged the duplicate heading and normalized the Unreleased section to match trunk byte-for-byte, which should keep subsequent backports conflict-free. Also verified every other file in this PR carries exactly the same changes as #80379 on trunk.

[andrewserong]

Nice one 👍

[adamsilverstein]

Rebased onto wp/7.1 now that #80421 is merged - the duplicate commit dropped cleanly and the PR is mergeable again. Ready to land once CI is green.

[andrewserong]

Ready to land once CI is green.

Looking good!

[t-hamano]

I would like to merge this PR, but it's a hassle to find out which PR actually made the change, as the recent entries in this changelog file link to issues rather than PRs. It would probably be better to fix this on both the trunk and wp/7.1 branches.

[adamsilverstein]

@t-hamano so the changelog entries should point to the PRs merged instead of the issue? I can go back and fix all of the client side media ones if thats helpful I likely did them all the same way.

[t-hamano]

so the changelog entries should point to the PRs merged instead of the issue?

There are no strict rules, but I believe changelog entries have been that way in the past. However, it's not urgent, so I think it's fine to correct it later 👍

[t-hamano]

I just cherry-picked this PR to the release/23.6 branch to get it included in the next release: e0a3943