Fix default aspect ratio for lazy loaded Featured image

[tellthemachines]

What?

Fixes #80378 by removing the explicit aspect ratio declaration when its value is auto.

Fwiw I was able to repro the bug in Chrome and Firefox, but not Safari.

Testing Instructions

1. Add a Query to a post or template, and ensure the posts or pages in it have featured images set.
2. Save and check that the featured images are sized correctly in the front end.

Screenshots or screencast

[github-actions]

Size Change: +10 B (0%)

Total Size: 7.73 MB

📦 View Changed

Filename	Size	Change
build/scripts/block-library/index.min.js	352 kB	+10 B (0%)

_{compressed-size-action}

[ramonjd]

With "aspectRatio":"auto" set on on the post-featured-image block, I can reproduce the bug. Confirmed that this fix addresses it. Good one!

Before	After

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: tommusrhodus <tommusrhodus@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[ramonjd]

Approving coz this works. Thanks a lot for the quick fix!!!!

I'm still not sure when "aspectRatio":"auto" is added. Looking into it, but LGTM for now.

[andrewserong]

LGTM!

While testing, I noticed that by not having an option to explicitly output auto it isn't possible via the UI to override an aspect ratio set elsewhere. I.e. if I have desktop layout set to a 16:9 aspect ratio, I can't make the mobile viewport set the aspect ratio to an explicit "original" / output auto deliberately.

While that's a gap in the responsive behaviour (or global styles -> individual block instance) hierarchy, in practice I doubt it's really much of an issue. I.e. who's going to set a pattern to 16:9 on desktop, but want intrinsic proportions on mobile? If this becomes an issue, I think we could treat that as a feature request.

For now, this fix seems like the right path forward to me.

[ramonjd]

I'm still not sure when "aspectRatio":"auto" is added. Looking into it, but LGTM for now.

This fix appears to be the right one. The conclusion is that the current UI never writes "aspectRatio":"auto" but it did once!

Before Gutenberg 23.5: the block had its own plain SelectControl (added in PR #47854, Feb 2023, ~Gutenberg 15.3 / WP 6.3) and "Original" was "value: 'auto',". The handler wrote the selection verbatim:

onChange={ ( nextAspectRatio ) =>
    setAttributes( { aspectRatio: nextAspectRatio } )
}

So only content saved with older Gutenberg versions (or hand-written markup) has this.

DimensionsTool explicitly treats 'auto' as "no value". Picking "Original" now removes aspectRatio from the markup entirely.

Sleuthed with help from Le Claude 🕺🏻

[github-actions]

I just cherry-picked this PR to the wp/7.1 branch to get it included in the next release: 1757a55

[t-hamano]

I just cherry-picked this PR to the release/23.6 branch to get it included in the next release: ce03c01