Perf-Dashboard.Render sync phase sets location.hash, but the actual DOM (#488)#496
Merged
Conversation
…OM (#488) modifications happen asynchronously in the onhashchange() callback. This results in nothing interesting being measured during the sync phase, and the resulting rendering update (during the async phase) not including the change. Change the test to manually and synchronously trigger the onhashchange() callback, and change the page content to detect and omit duplicate events. Co-authored-by: Matt Woodrow <m_woodrow@apple.com>
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flashdesignory
approved these changes
Mar 1, 2025
julienw
approved these changes
Mar 3, 2025
camillobruni
added a commit
to camillobruni/Speedometer
that referenced
this pull request
Jun 2, 2026
b475f2d Perf-Dashboard.Render sync phase sets location.hash, but the actual DOM (WebKit#488) (WebKit#496) b270564 (origin/3.1, 3.1) Release/3.1 428 - add id to input (NEW - with correct base to merge into) (WebKit#494) aba1d5e (thor/release/3.1, flashd/release/3.1) Deconfuse Geomean Metric and geomean aggregate value (WebKit#408) (WebKit#480) ce03cfb Don't display invalid results (WebKit#406) (WebKit#479) 6f25345 Update Version Text from 3.0 to 3.1 (WebKit#485) cc9ee08 Release/3.1 - merge 400 (rename className -> class) (WebKit#483) e12e84c Release/3.1 - merge 448 (news site article ids nuxt) (WebKit#482) 8a4a566 Release/3.1 - merge 447 (news site article ids next) (WebKit#481) Change-Id: If0b19391128b82389eda1a61d33dc4e2be2cd180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modifications happen asynchronously in the onhashchange() callback.
This results in nothing interesting being measured during the sync phase, and the resulting rendering update (during the async phase) not including the change.
Change the test to manually and synchronously trigger the onhashchange() callback, and change the page content to detect and omit duplicate events.