Don't display invalid results#406
Merged
camillobruni merged 9 commits intoJul 25, 2024
Merged
Conversation
Contributor
|
should we display a message to the user, explaining what happened and that the details view might have useful information? |
Contributor
Author
|
Updated version with a better description: |
Member
|
Rather than "Invalid Score", how about "Error"? Also, we should probably stop right away when we detect an invalid value instead of running 'til completion. |
Contributor
Author
|
Contributor
Author
|
Updated the code to stop after the first iteration with a broken score (tracking errors across the TestInvoker seems a bit more tricky at the moment). |
julienw
approved these changes
Apr 9, 2024
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
I don't have a strong opinion about the exact behavior but this looks reasonable to me. Thanks!
rniwa
reviewed
Apr 9, 2024
julienw
reviewed
Apr 10, 2024
flashdesignory
approved these changes
May 29, 2024
Contributor
Author
|
@rniwa could you have another look maybe? |
Contributor
Author
|
@rniwa do you have additional feedback or would be ok with landing with your proposed changes? |
rniwa
approved these changes
Jul 24, 2024
camillobruni
added a commit
to camillobruni/Speedometer
that referenced
this pull request
Jan 29, 2025
This partially fixes WebKit#399 by not display non-finite scores which are caused by 0-measured suite results. - For non-positive or non-finite scores, the following summary page is displayed. Note that the detailed page is still accessible since you might find some useful information there. - Additionally, a console.error is generated for each zero-sum suite
camillobruni
added a commit
that referenced
this pull request
Feb 18, 2025
This partially fixes #399 by not display non-finite scores which are caused by 0-measured suite results. - For non-positive or non-finite scores, the following summary page is displayed. Note that the detailed page is still accessible since you might find some useful information there. - Additionally, a console.error is generated for each zero-sum suite - Merge of original PR #406
camillobruni
added a commit
to camillobruni/Speedometer
that referenced
this pull request
Jun 2, 2026
b475f2d Perf-Dashboard.Render sync phase sets location.hash, but the actual DOM (WebKit#488) (WebKit#496) b270564 (origin/3.1, 3.1) Release/3.1 428 - add id to input (NEW - with correct base to merge into) (WebKit#494) aba1d5e (thor/release/3.1, flashd/release/3.1) Deconfuse Geomean Metric and geomean aggregate value (WebKit#408) (WebKit#480) ce03cfb Don't display invalid results (WebKit#406) (WebKit#479) 6f25345 Update Version Text from 3.0 to 3.1 (WebKit#485) cc9ee08 Release/3.1 - merge 400 (rename className -> class) (WebKit#483) e12e84c Release/3.1 - merge 448 (news site article ids nuxt) (WebKit#482) 8a4a566 Release/3.1 - merge 447 (news site article ids next) (WebKit#481) Change-Id: If0b19391128b82389eda1a61d33dc4e2be2cd180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially fixes #399 by not display non-finite scores which are caused by 0-measured suite results.
console.erroris generated for each zero-sum suite