支持修改输出plugin.zip的文件名和路径 - #84
Merged
Merged
Conversation
Member
Closed
shifujun
requested changes
Aug 6, 2019
shifujun
left a comment
Collaborator
There was a problem hiding this comment.
看起来兼顾了原有逻辑。但造成了prefix和suffix的设置方式不一样。需要
- 将两个设置方式统一。
- 在sample中演示用法。
Contributor
Author
done |
Contributor
Author
|
@shifujun 抽空看下是否OK了? |
shifujun
requested changes
Aug 16, 2019
shifujun
left a comment
Collaborator
There was a problem hiding this comment.
两个问题:
- 对PluginSuffix环境变量的兼容写在了sample里,如果要兼容应该写在SDK里。
2.现在的逻辑当suffix为空时,archiveName最后会是-.zip,而之前是没有-的。
Contributor
Author
问题1:大部分配置都通过extension对外暴露,唯独suffix通过环境变量设置,感觉已经不统一了,既然要通过extension暴露的接口来设置,不如全部用extension |
Contributor
Author
关于问题2,按照代码的含义,输出应该是相当于下表:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.