Skip to content

支持修改输出plugin.zip的文件名和路径 - #84

Merged
shifujun merged 2 commits into
Tencent:devfrom
PhantomQi:pr_20190805_1320_3
Aug 20, 2019
Merged

支持修改输出plugin.zip的文件名和路径#84
shifujun merged 2 commits into
Tencent:devfrom
PhantomQi:pr_20190805_1320_3

Conversation

@PhantomQi

Copy link
Copy Markdown
Contributor

No description provided.

@tencent-adm

tencent-adm commented Aug 5, 2019

Copy link
Copy Markdown
Member

CLA assistant check
All committers have signed the CLA.

@shifujun shifujun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来兼顾了原有逻辑。但造成了prefix和suffix的设置方式不一样。需要

  1. 将两个设置方式统一。
  2. 在sample中演示用法。

@PhantomQi

Copy link
Copy Markdown
Contributor Author

看起来兼顾了原有逻辑。但造成了prefix和suffix的设置方式不一样。需要

  1. 将两个设置方式统一。
  2. 在sample中演示用法。

done

@PhantomQi

Copy link
Copy Markdown
Contributor Author

@shifujun 抽空看下是否OK了?

@shifujun shifujun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个问题:

  1. 对PluginSuffix环境变量的兼容写在了sample里,如果要兼容应该写在SDK里。
    2.现在的逻辑当suffix为空时,archiveName最后会是-.zip,而之前是没有-的。

@PhantomQi

Copy link
Copy Markdown
Contributor Author

两个问题:

  1. 对PluginSuffix环境变量的兼容写在了sample里,如果要兼容应该写在SDK里。
    2.现在的逻辑当suffix为空时,archiveName最后会是-.zip,而之前是没有-的。

问题1:大部分配置都通过extension对外暴露,唯独suffix通过环境变量设置,感觉已经不统一了,既然要通过extension暴露的接口来设置,不如全部用extension
问题2:我看下

@PhantomQi

Copy link
Copy Markdown
Contributor Author

两个问题:

  1. 对PluginSuffix环境变量的兼容写在了sample里,如果要兼容应该写在SDK里。
    2.现在的逻辑当suffix为空时,archiveName最后会是-.zip,而之前是没有-的。

关于问题2,按照代码的含义,输出应该是相当于下表:

prefix=空 prefix=A
suffix=空 plugin-debug.apk A-debug.apk
suffix=B plugin-debug-B.apk A-debug-B.apk

@shifujun shifujun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这回看明白了。还是得有机会补个单元测试。

@shifujun
shifujun changed the base branch from master to dev August 20, 2019 03:16
@shifujun
shifujun merged commit 55f27b9 into Tencent:dev Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants