对Shadow的一些非核心逻辑做了一些增强 - #79
Closed
PhantomQi wants to merge 5 commits into
Closed
Conversation
Member
|
|
Collaborator
|
非常感谢对Shadow贡献代码！ 我目前在休假，估计要下周一才能在电脑上仔细验证代码。 建议将这5个比较独立的改动分成5个PR，如果它们之间不相互依赖的话。因为有的改动可能很容易合入，有的改动可能还需要讨论修改。 简单看了一下，比如直接用系统的Log接口输出Log可能不够好，所以我们专门定义了用户可以设置进来的Log接口。还有将不再需要的代码注释掉，而不是删除掉也不够好。当然这些细节问题不大，我可以合入后再修改。 有些改动可能会影响原有逻辑，至少要保证testSdk任务没问题，这个我得下周用电脑再验证了。 再次感谢贡献代码！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.