lr-mame: branch name should not be empty - #4209
Open
cmitu wants to merge 1 commit into
Open
Conversation
... otherwise the update/install will pass an empty string to `git ls-remote` and the operation fails, leading to: - `git ls-remote` failing in the background (with an additional 'are you connected to the internet' message added). - the update dialog showing 'no install options available' and leaving only the removal or the package as an option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... otherwise the update/install will pass an empty string to
git ls-remoteand the operation fails, leading to:git ls-remotefailing in the background because it checks for and empty branch (with an additional 'are you connected to the internet' message added)NB: the empty branch propagates to
retropie.pkg, which may also have a say in the erroneous update check fromrp_getRemoteRepoHash.Should fix #4204