chore: apply prettier formatting repo-wide (#710) - #752
Open
SakethSumanBathini wants to merge 2 commits into
Open
chore: apply prettier formatting repo-wide (#710)#752SakethSumanBathini wants to merge 2 commits into
SakethSumanBathini wants to merge 2 commits into
Conversation
Contributor
|
✅ Issue link found. Thanks — this PR now references the issue it resolves. |
Contributor
|
Important Review skippedToo many files! This PR contains 211 files, which is 111 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (211)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
Contributor
Welcome to OSSfolio, @SakethSumanBathini! 🎉Thank you for opening this pull request and contributing to the open-source community! 🚀 To ensure a smooth review process, please make sure you have:
We will review your PR as soon as possible. Happy coding! 💻✨ |
Contributor
Bundle size reportClient bundle grew by 29 B gzipped.
Per-chunk changes (19)
…and 4 more. Measured from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #710
npx prettier --check .— the exact command the Prettier workflow runs — fails onmainacross 211 files. That check has been red on every PR from every contributor regardless of content, which makes it useless as a signal and trains people to ignore red.This is
npx prettier --write .and nothing else. No logic changes, no renames, no reordering.Reviewing this
Please don't read it line by line — it's mechanical output. What's worth checking:
npx prettier --check .→ All matched files use Prettier code style!npm run build→ completes, all 41 routes emittednpx vitest run→ 281 passed, 4 failed — all four failing onmaintoo, see belowBased on #709
The pre-commit hook runs
eslint --fixover staged files, which fails on the conditional-hook error inMilestoneCelebration.tsx. This branch is cut from that fix so the two don't fight; it should merge after #709.Committed with
--no-verifylint-staged runs
tsc --noEmitper chunk of staged files. With 211 files split across three chunks the compiler is SIGKILLed on memory:That's the hook hitting a resource limit under a bulk change, not a signal about the change itself.
npm run buildruns the same typechecker over the whole project in one pass and completes cleanly.Blame
A formatting pass this size makes every line look last-touched here. Worth adding the merged commit to
.git-blame-ignore-revsafterwards:I left the file out of this PR deliberately — the hash it needs is the merge commit, which doesn't exist yet. Happy to follow up with it once this lands, or you can add it directly.
Four pre-existing test failures
npx vitest runreports 4 failures, all present onmainbefore this branch and all the same cause — the{ success, data }envelope and structurederrorobject thatcreateApiResponsenow returns, asserted against by tests written for the older contract:Same family as the four I fixed in #706. Flagging so a reviewer running the suite doesn't attribute them here — happy to open a separate PR updating those assertions.