Skip to content

[CI] Prettier and Build & Lint checks fail on every PR — both are pre-existing on main #710

Description

@SakethSumanBathini

Two required checks fail on every pull request regardless of its contents, which makes them useless as signals and trains reviewers to ignore red.

Prettier Code Formatting — the workflow runs npx prettier --check . repo-wide. Clean main @ bd9bfc0:

[warn] Code style issues found in 242 files.

CI - Build & Linteslint src/ exits non-zero on a single error:

src/components/profile/MilestoneCelebration.tsx
  101:31  error  React Hook "React.useState" is called conditionally.  react-hooks/rules-of-hooks

✖ 62 problems (1 error, 61 warnings)

Both reproduce identically on main with no changes applied.

Suggested fixes, each as its own PR since they're mechanically unrelated:

  1. npx prettier --write . — one large formatting commit, ideally added to .git-blame-ignore-revs so it doesn't pollute blame
  2. Fix the conditional useState in MilestoneCelebration.tsx — that one's a genuine React violation rather than a style issue, since hook identity depends on call order

Filed separately from #708 because these affect every contributor, not just the webhook tests.

Metadata

Metadata

Labels

bugSomething is not working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions