Skip to content

在陶瓦联机页面向非中国内地用户添加提示框 - #4869

Merged
Glavo merged 7 commits into
HMCL-dev:mainfrom
Glavo:terracotta
Nov 30, 2025
Merged

在陶瓦联机页面向非中国内地用户添加提示框#4869
Glavo merged 7 commits into
HMCL-dev:mainfrom
Glavo:terracotta

Conversation

@Glavo

@Glavo Glavo commented Nov 27, 2025

Copy link
Copy Markdown
Member

还有一种选择是不强制弹窗,检测到非中国大陆地区就在陶瓦联机页面最上面放一个警告框。

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a regional availability warning for the Terracotta multiplayer feature when accessed by users outside Mainland China. The warning appears as a non-intrusive HintPane at the top of the Terracotta controller page instead of a blocking dialog.

  • Adds localized warning messages in Simplified Chinese, Traditional Chinese, and English
  • Displays a yellow warning banner on the Terracotta page for non-Mainland China users
  • Refactors imports to use wildcard notation consistent with codebase conventions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
I18N_zh_CN.properties Adds Simplified Chinese warning message about regional service availability
I18N_zh.properties Adds Traditional Chinese warning message about regional service availability
I18N.properties Adds English warning message about regional service availability
TerracottaControllerPage.java Implements region detection and displays warning HintPane for non-Mainland China users

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
terracotta.unsupported.os.windows.old=Multiplayer requires Windows 10 or later. Please update your system.
terracotta.unsupported.arch.32bit=Multiplayer is not supported on 32-bit systems. Please upgrade to a 64-bit system.
terracotta.unsupported.arch.loongarch64_ow=Multiplayer is not supported on Linux LoongArch64 Old World distributions. Please update to a New World distribution (such as AOSC OS).
terracotta.unsupported.region=The multiplayer feature is currently only available to users in Mainland China and may not be available in your region.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一年前:#3367 (comment)

现在应该用哪个词呢?想知道 Glavo 怎么看

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在应该用哪个词呢?想知道 Glavo 怎么看

AI 翻译的,我没注意看。

根据官方的意见,应该总是使用 Chinese Mainland 这个称呼,另一个称呼存在政治上的风险。稍后我会把它加入 Gradle 自动检测规则里。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI 翻译的,我没注意看。

根据官方的意见,应该总是使用 Chinese Mainland 这个称呼,另一个称呼存在政治上的风险。稍后我会把它加入 Gradle 自动检测规则里。

行。

@Glavo Glavo changed the title 在非中国内地打开陶瓦联机页面时弹出警告框 在陶瓦联机页面对非中国内地用户添加警告提示 Nov 30, 2025
@Glavo Glavo changed the title 在陶瓦联机页面对非中国内地用户添加警告提示 在陶瓦联机页面向非中国内地用户添加提示框 Nov 30, 2025
@Glavo
Glavo merged commit 75292d2 into HMCL-dev:main Nov 30, 2025
2 checks passed
@Glavo
Glavo deleted the terracotta branch November 30, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants