Skip to content

i18n overhaul & minor UI changes - #3150

Closed
3gf8jv4dv wants to merge 2 commits into
HMCL-dev:mainfrom
3gf8jv4dv:i18n-ui-adjust
Closed

i18n overhaul & minor UI changes#3150
3gf8jv4dv wants to merge 2 commits into
HMCL-dev:mainfrom
3gf8jv4dv:i18n-ui-adjust

Conversation

@3gf8jv4dv

Copy link
Copy Markdown
Contributor

Work in progress...

The original idea came from #3129 (comment). After reviewing the i18n files, I felt that there were some opinions, so I started working on it.

This PR should not be considered a replacement for some PR. Welcome to review and make suggestions.

Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated
Comment thread HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties Outdated
settings.show_log=查看日志
settings.skin=现已支持离线账户更换皮肤,你可以到账户页面更改离线账户的皮肤和披风(多人游戏下其他玩家无法看到你的皮肤)
settings.tabs.installers=自动安装
settings.tabs.installers=版本管理

@burningtnt burningtnt Jun 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不赞成重命名 自动安装版本管理。这会导致已有的用户习惯被打破
上方英文部分中,我也同样不赞成重命名 ModLoader / OptiFineVersion。这也会导致已有用户的习惯被打破

我理解,目前英文中的 ModLoader / OptiFine 并不能准确代表这个页面的作用(毕竟这个页面确实是管理各种组件的),但直接重命名为 Version 会导致更大的误解

@3gf8jv4dv 3gf8jv4dv Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your comment on the Chinese part. I have reverted it and will push it later.

I have reservations about the English part - it still needs to be revised. Here are the reasons:

  • At present, the user base of HMCL is mainly mainland users, and the revision of other languages is unlikely to have a big impact
  • In English, ModLoader / OptiFine really cannot accurately express the function of the page.
  • In English, ModLoader / OptiFine is slightly longer. After setting the HMCL language to English (US), OptiFine will be partially truncated.

The English part has temporarily reverted to ModLoader / OptiFine.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native speaker of Enligh. Therefore I only believe Version is worse than ModLoader / OptiFine. However, We do need a better idea.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burningtnt

The word Components suddenly comes to mind, what do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word Components suddenly comes to mind, what do you think?

I'm not a native speaker of Enligh. :( I believe in you.

Comment thread HMCL/src/main/resources/assets/lang/I18N.properties Outdated
@3gf8jv4dv

Copy link
Copy Markdown
Contributor Author

Plans to split into several different PRs to replace it.

@3gf8jv4dv 3gf8jv4dv closed this Aug 23, 2024
@3gf8jv4dv
3gf8jv4dv deleted the i18n-ui-adjust branch August 23, 2024 18:59
@3gf8jv4dv 3gf8jv4dv mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants