更改主页 UI - #3129
Conversation
burningtnt
commented
Jun 16, 2024
burningtnt
commented
Co-authored-by: 3gf8jv4dv <158490944+3gf8jv4dv@users.noreply.github.com>
3gf8jv4dv
left a comment
3gf8jv4dv
left a comment
There was a problem hiding this comment.
1e68198 (#3129), burningtnt/HMCL/actions/runs/9534351876
The current UI design does not mesh well with the English strings changed by this PR. When the user is in English, the last word of Game Instance Settings is blocked. I cannot find a way to make the left sidebar wider.
Preview
|
How about changing 'Game Instance Settings' to a shorter phrase? |
Sure. |
Can you provide any suggestion? I'm not a native Enligsh spaker. |
Instance Settings is all it takes. Prism Launcher also adopts this description. |
|
|
Off topic. It occurred to me that there are similar issues in several other places in the launcher, but those issues are different from this PR and can basically be solved by modifying the i18n files. Should I create a PR to fix the above issues? |
You are always welcomed to contribute. Thanks! |
…e/change-root-page-ui
|
@Glavo What do you think? I think it is a good change, it matches the launch button in the bottom right corner of the home page, and it lets users know exactly what this button does. Note that the i18n parts in this PR are outdated — I replaced them with new translations in some recent PRs. |
# Conflicts: # HMCL/src/main/resources/assets/lang/I18N.properties # HMCL/src/main/resources/assets/lang/I18N_zh.properties # HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties
3 participants
