Skip to content

[Fix]Add team to the CallViewModel and CallViewController #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ipavlidakis merged 2 commits into from
May 22, 2025
Merged

[Fix]Add team to the CallViewModel and CallViewController #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81b72d0
[Fix]Add team to the CallViewModel and CallViewController
ipavlidakis May 21, 2025
6f6eb0f
Update changelog
ipavlidakis May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### ✅ Added
- `CallViewController` was updated to accept the `video` flag when starting a call. [#811](https://github.com/GetStream/stream-video-swift/pull/811)
- `team` property when creating calls through `CallViewModel` and/or `CallViewController` [#817](https://github.com/GetStream/stream-video-swift/pull/817)

### 🐞 Fixed
- Fix a retain cycle that was causing StreamVideo to leak in projects using NoiseCancellation. [#814](https://github.com/GetStream/stream-video-swift/pull/814)
Expand Down
7 changes: 6 additions & 1 deletion Sources/StreamVideoSwiftUI/CallViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ open class CallViewModel: ObservableObject {
callType: String,
callId: String,
members: [Member],
team: String? = nil,
ring: Bool = false,
maxDuration: Int? = nil,
maxParticipants: Int? = nil,
Expand All @@ -353,6 +354,7 @@ open class CallViewModel: ObservableObject {
callType: callType,
callId: callId,
members: membersRequest ?? [],
team: team,
ring: ring,
maxDuration: maxDuration,
maxParticipants: maxParticipants,
Expand All @@ -372,6 +374,7 @@ open class CallViewModel: ObservableObject {
let callData = try await call.create(
members: membersRequest,
custom: customData,
team: team,
ring: ring,
maxDuration: maxDuration,
maxParticipants: maxParticipants,
Expand Down Expand Up @@ -636,6 +639,7 @@ open class CallViewModel: ObservableObject {
callType: String,
callId: String,
members: [MemberRequest],
team: String? = nil,
ring: Bool = false,
maxDuration: Int? = nil,
maxParticipants: Int? = nil,
Expand Down Expand Up @@ -664,7 +668,8 @@ open class CallViewModel: ObservableObject {
members: members,
custom: customData,
settings: settingsRequest,
startsAt: startsAt
startsAt: startsAt,
team: team
)
let settings = localCallSettingsChange ? callSettings : nil

Expand Down
2 changes: 2 additions & 0 deletions Sources/StreamVideoUIKit/CallViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,15 @@ open class CallViewController: UIViewController {
callType: String,
callId: String,
members: [Member],
team: String? = nil,
ring: Bool = false,
video: Bool? = nil
) {
viewModel.startCall(
callType: callType,
callId: callId,
members: members,
team: team,
ring: ring,
video: video
)
Expand Down