Skip to content

[Fix]Add team to the CallViewModel and CallViewController - #817

Merged
ipavlidakis merged 2 commits into
developfrom
enhancement/allow-team-passing-when-starting-a-call
May 22, 2025
Merged

ipavlidakis merged 2 commits into
developfrom
enhancement/allow-team-passing-when-starting-a-call

Conversation

@ipavlidakis

Copy link
Copy Markdown
Contributor

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-878/add-teamfield-when-creating-a-call-from-callviewmodel-and

🎯 Goal

Allow passing the team parameter when creating a call from CallViewModel and CallViewController.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis self-assigned this May 21, 2025
@ipavlidakis ipavlidakis added the enhancement New feature or request label May 21, 2025
@github-actions

Copy link
Copy Markdown

Public Interface

 @MainActor open class CallViewController: UIViewController  
-   public func startCall(callType: String,callId: String,members: [Member],ring: Bool = false,video: Bool? = nil)
+   public func startCall(callType: String,callId: String,members: [Member],team: String? = nil,ring: Bool = false,video: Bool? = nil)

 @MainActor open class CallViewModel: ObservableObject  
-   public func startCall(callType: String,callId: String,members: [Member],ring: Bool = false,maxDuration: Int? = nil,maxParticipants: Int? = nil,startsAt: Date? = nil,backstage: BackstageSettingsRequest? = nil,customData: [String: RawJSON]? = nil,video: Bool? = nil)
+   public func startCall(callType: String,callId: String,members: [Member],team: String? = nil,ring: Bool = false,maxDuration: Int? = nil,maxParticipants: Int? = nil,startsAt: Date? = nil,backstage: BackstageSettingsRequest? = nil,customData: [String: RawJSON]? = nil,video: Bool? = nil)

@ipavlidakis
ipavlidakis marked this pull request as ready for review May 21, 2025 14:05
@ipavlidakis
ipavlidakis requested a review from a team as a code owner May 21, 2025 14:05
@Stream-SDK-Bot

Stream-SDK-Bot commented May 21, 2025

Copy link
Copy Markdown
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.54 MB 7.54 MB 0 KB 🟢
StreamVideoSwiftUI 2.26 MB 2.26 MB 0 KB 🟢
StreamVideoUIKit 2.38 MB 2.38 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@github-actions

Copy link
Copy Markdown

Public Interface

 @MainActor open class CallViewModel: ObservableObject  
-   public func startCall(callType: String,callId: String,members: [Member],ring: Bool = false,maxDuration: Int? = nil,maxParticipants: Int? = nil,startsAt: Date? = nil,backstage: BackstageSettingsRequest? = nil,customData: [String: RawJSON]? = nil,video: Bool? = nil)
+   public func startCall(callType: String,callId: String,members: [Member],team: String? = nil,ring: Bool = false,maxDuration: Int? = nil,maxParticipants: Int? = nil,startsAt: Date? = nil,backstage: BackstageSettingsRequest? = nil,customData: [String: RawJSON]? = nil,video: Bool? = nil)

 @MainActor open class CallViewController: UIViewController  
-   public func startCall(callType: String,callId: String,members: [Member],ring: Bool = false,video: Bool? = nil)
+   public func startCall(callType: String,callId: String,members: [Member],team: String? = nil,ring: Bool = false,video: Bool? = nil)

@sonarqubecloud

Copy link
Copy Markdown

@ipavlidakis
ipavlidakis merged commit bef1fe8 into develop May 22, 2025
@ipavlidakis
ipavlidakis deleted the enhancement/allow-team-passing-when-starting-a-call branch May 22, 2025 08:31
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants