Skip to content

Append suffixes correctly for phpcpd #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zdenekdrahos merged 4 commits into from
Feb 4, 2023
Merged

Append suffixes correctly for phpcpd #253

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d59fdcf
Append suffixes correctly for phpcpd
omarlopesino Jan 17, 2023
ea6b1c5
Coding style
omarlopesino Jan 17, 2023
1abf845
Coding Style
omarlopesino Jan 17, 2023
b9e71d4
Safer way to format the phpcpd arguments
omarlopesino Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Tools/Analyzer/Phpcpd.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ function ($extension) use ($isOlderVersion) {
$args['progress'] = '';
}
if ($phpcpdNames) {
$namesOptions = $isOlderVersion ? 'names' : 'suffix';
$args[$namesOptions] = \Edge\QA\escapePath(implode(',', $phpcpdNames));
if ($isOlderVersion) {
$args['names'] = \Edge\QA\escapePath(implode(',', $phpcpdNames));
} else {
foreach ($phpcpdNames as $name) {
$args[] = '--suffix "' . \Edge\QA\escapePath($name) . '"';
Comment thread
omarlopesino marked this conversation as resolved.
Outdated
}
}
}
if ($this->options->isSavedToFiles) {
$args['log-pmd'] = $this->tool->getEscapedXmlFile();
Expand Down