Append suffixes correctly for phpcpd#253
Merged
Merged
Conversation
zdenekdrahos
requested changes
Jan 18, 2023
Contributor
Author
Contributor
Author
|
I've done the requested changes. Please review, thanks! |
zdenekdrahos
approved these changes
Feb 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Since phpcpd has released the 6.0 version the --names have been removed in favour of the new argument --suffix. This change has been adapted at PHPqa project but it needs a correction.
CUrrently, the --suffix arguments is added by joining all the suffixes by commas. Example:
--suffix="*.php,*.theme,*.module"But that syntax is not correct. This is the documentation of the suffix command from PHPcpd:
The suffix parameter only accepts one suffix, and if it is needed to add more suffixes, the --suffix parameter must be repeated. So, the example I shown below should be corrected to this:
This pull request fixes the usage of suffix to be added by repeating suffix arguments and not joining the suffixes by commas. Please review, thanks!