Skip to content

Tools - refactoring testing different php versions and installing suggested tools#220

Merged
zdenekdrahos merged 8 commits into
masterfrom
suggested-tools-2021
Feb 5, 2021
Merged

Tools - refactoring testing different php versions and installing suggested tools#220
zdenekdrahos merged 8 commits into
masterfrom
suggested-tools-2021

Conversation

@zdenekdrahos

@zdenekdrahos zdenekdrahos commented Feb 4, 2021

Copy link
Copy Markdown
Member

Related to changes in #218. New security-checker and psalm/php-cs-fixer needs at least Symfony3. Symfony2 is required only for PHP 5.4 (5.4 vs 5.5).

  • refactoring suggested-tools.sh and php.yml
  • use default composer.lock and symfony2 suggested tools only for php 5.4

- don't restrict phpunit version, composer should select correct version
- install suggested tools for php5

https://github.com/EdgedesignCZ/phpqa/pull/220/checks?check_run_id=1829726513#step:5:74
  Package phpstan/phpstan at version  has a PHP requirement incompatible with your PHP version (5.6.40)
- test default composer.lock, default composer.lock + suggested tools and updated composer.lock + suggested tools
- always --ignore-platform-reqs (following commands will fail, if there are troubles)
- requireMode is not necessary for detecting symfony2/symfonyX versions
@zdenekdrahos zdenekdrahos force-pushed the suggested-tools-2021 branch 5 times, most recently from cece34e to b7fcf1b Compare February 5, 2021 12:28
@zdenekdrahos zdenekdrahos changed the title Tools - suggested tools experiments Tools - refactoring testing different php versions and installing suggested tools Feb 5, 2021
@zdenekdrahos zdenekdrahos marked this pull request as ready for review February 5, 2021 12:48
@zdenekdrahos zdenekdrahos merged commit ed0b85b into master Feb 5, 2021
@zdenekdrahos zdenekdrahos deleted the suggested-tools-2021 branch February 5, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant