Skip to content

Replace abandoned Sensiolabs security checker#215

Merged
zdenekdrahos merged 3 commits into
EdgedesignCZ:masterfrom
paras-malhotra:master
Feb 5, 2021
Merged

Replace abandoned Sensiolabs security checker#215
zdenekdrahos merged 3 commits into
EdgedesignCZ:masterfrom
paras-malhotra:master

Conversation

@paras-malhotra

Copy link
Copy Markdown
Contributor

This PR replaces the abandoned Sensiolabs security checker with the Enlightn security checker.

https://github.com/sensiolabs/security-checker
Jan 15 2021
WARNING: Don't use this piece of software anymore as the underlying web service will stop working at the end of January 2021.
@paras-malhotra

Copy link
Copy Markdown
Contributor Author

This PR has several advantages over #214:

  1. The Enlightn security checker is licensed under MIT so it can be used in any app. The other PR uses local php security checker which is licensed under AGPLv3, and thus cannot be used by any non-AGPL app.
  2. This Enlightn security checker can be pulled in via composer whereas the local-php-security-checker needs to download binaries. This depends on system architecture and needs hacky solutions / shell scripts to make it work.

@zdenekdrahos

Copy link
Copy Markdown
Member

Looks interesting. Composer.lock is not uploaded anywhere, am I correct?

@paras-malhotra

Copy link
Copy Markdown
Contributor Author

That's right @zdenekdrahos, it just looks for the lock file in the current directory. It's very similar to how the old Sensiolabs security-checker worked.

@zdenekdrahos

Copy link
Copy Markdown
Member

Could you support symfony/finder:2? I'd like to keep support for older php and symfony versions.

https://travis-ci.org/github/EdgedesignCZ/phpqa/jobs/756550442#L596
enlightn/security-checker v1.3 requires symfony/finder ^3|^4|^5 but these conflict with your requirements or minimum-stability.

@paras-malhotra

Copy link
Copy Markdown
Contributor Author

Hey @zdenekdrahos, I've added support all the way upto PHP 5.6 with enlightn/security-checker#6. We need a min of symfony/yaml 3.4 and symfony/console 3.4 for everything to work right now.

Given that 5.6 was EOL in 2018, I think it's a good version to support for now. I'm open to PRs for expanding support though but this as far as I can get for now. Hope that works!

https://github.com/EdgedesignCZ/phpqa/pull/215/checks?check_run_id=1830905399
- Package enlightn/security-checker at version has a PHP requirement incompatible with your PHP version (5.4.45)

https://github.com/EdgedesignCZ/phpqa/pull/215/checks?check_run_id=1830905455
https://github.com/EdgedesignCZ/phpqa/runs/1838836954?check_suite_focus=true#step:5:130
- enlightn/security-checker v1.4 requires ext-zip * -> the requested PHP extension zip is missing from your system.

https://github.com/EdgedesignCZ/phpqa/pull/215/checks?check_run_id=1830905569#step:5:316
- Conclusion: don't install symfony/dependency-injection v2.8.50
- enlightn/security-checker v1.4 requires symfony/console ^3.4|^4|^5
@zdenekdrahos zdenekdrahos force-pushed the master branch 2 times, most recently from 29e5593 to 752bbb0 Compare February 5, 2021 12:59
@zdenekdrahos zdenekdrahos merged commit 1639b48 into EdgedesignCZ:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Symfony security-checker archived

2 participants