Skip to content

fix(swoole): gate post body parsing on allowed post params #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwoebi merged 1 commit into from
May 28, 2026
Merged

fix(swoole): gate post body parsing on allowed post params #3931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/DDTrace/Integrations/Swoole/SwooleIntegration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,18 @@ static function (HookData $hook) use ($server, $scheme) {
$rootSpan->meta["http.useragent"] = $headers["user-agent"];
}

$rawContent = $request->rawContent();
if ($rawContent) {
// The raw content will always be populated if the request is a POST request, independent of the
// Content-Type header.
// However, it may not be json-decodable
$postFields = json_decode($rawContent, true);
if (is_null($postFields)) {
// Fallback to the post fields, which is an array
// This array is not always populated, depending on the Content-Type header
$postFields = $request->post;
if (!empty(\dd_trace_env_config('DD_TRACE_HTTP_POST_DATA_PARAM_ALLOWED'))) {
$rawContent = $request->rawContent();
if ($rawContent) {
// The raw content will always be populated if the request is a POST request, independent of
// the Content-Type header.
// However, it may not be json-decodable
$postFields = json_decode($rawContent, true);
if (is_null($postFields)) {
// Fallback to the post fields, which is an array
// This array is not always populated, depending on the Content-Type header
$postFields = $request->post;
}
}
}
if (!empty($postFields)) {
Expand Down
Loading