fix(swoole): gate post body parsing on allowed post params#3931
Merged
Conversation
|
tabgok
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
$request->rawContent()andjson_decode()then normalized and added every parsed POST parameter name to span metadata even whenDD_TRACE_HTTP_POST_DATA_PARAM_ALLOWEDis empty, allowing unauthenticated clients to force expensive parsing and metadata growth.Description
SwooleIntegration::instrumentRequestStart()so request body reading and decoding only runs whenDD_TRACE_HTTP_POST_DATA_PARAM_ALLOWEDis non-empty (changed file:src/DDTrace/Integrations/Swoole/SwooleIntegration.php).Normalizer::sanitizePostFields()and metadata-writing behavior when POST parameter capture is explicitly enabled.Testing
php -l src/DDTrace/Integrations/Swoole/SwooleIntegration.phpto validate syntax, which succeeded.Codex Task