Skip to content

improve resource loading performance when updating - #77

Open
atitan wants to merge 1 commit into
zorab47:masterfrom
atitan:master
Open

improve resource loading performance when updating#77
atitan wants to merge 1 commit into
zorab47:masterfrom
atitan:master

Conversation

@atitan

@atitan atitan commented Aug 21, 2018

Copy link
Copy Markdown

The original creates a lot of N+1 queries when collection set is large.

Query everything in the first place and assign them.

@zorab47

zorab47 commented Aug 28, 2018

Copy link
Copy Markdown
Owner

Nice! Is there a maximum number of records where performance degrades?

@atitan

atitan commented Aug 30, 2018

Copy link
Copy Markdown
Author

Currently we have 300+ categories listing as a tree.
It takes about 15~20 seconds to update for every single drag in the admin panel.

I was able to cut it down to 2 seconds with this patch.

@zorab47

zorab47 commented Sep 2, 2018 via email

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants