fix steering baseline#701
Open
xwh12345-user wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes ori_generate() / ori_vllm_generate() so original predictions are generated without active interventions.
What Changed
Added shared generation-state helpers in steer/models/model_wrapper.py:
ori_generate() now temporarily clears and restores both:
ori_vllm_generate() now applies the same cleanup/restore logic.
GPTWrapper.ori_generate() was also updated to use the shared helper logic.
This ensures orig_pred is generated from the base model state, without being affected by RePS/SFT/SPILT-style interventions stored
in intervention_dict.
What Was Tested
Static checks:
Unit-style state restoration test:
Real-model tests on GPU 0:
Results
Qwen2.5-7B-Instruct
Qwen3-VL-4B-Instruct