CI: Drop JDK 11, add JDK 25 - #1626
Open
guizmaii wants to merge 1 commit into
Open
Conversation
sideeffffect
left a comment
sideeffffect
left a comment
Member
There was a problem hiding this comment.
It's fine to up the version where we run the tests etc.
But unless we have a good reason, we can keep publishing on 11, AFAIK there's nothing pushing us to move beyond.
| uses: actions/setup-java@v5.2.0 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 # ensure it works on 11 because we publish for 11 |
Member
There was a problem hiding this comment.
Keep 11 here, as the comment says, it's important to know we can publish on 11
| uses: actions/setup-java@v5.2.0 | ||
| with: | ||
| distribution: temurin | ||
| java-version: '11' |
| uses: actions/setup-java@v5.2.0 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 # publish for 11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testJvmsmatrix and replace it with JDK 25publishLocal,publish, andrelease-docsjobs