Import new device diagnostics - #857
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #857 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 55 55
Lines 10482 10482
=======================================
Hits 10184 10184
Misses 298 298 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request adds new device diagnostics fixture files under tests/data/devices, expanding the repository’s regression coverage for ZHA’s get_diagnostics_json() output across additional devices/firmware variants.
Changes:
- Added multiple new device diagnostics JSON fixtures for Tuya, Sonoff, Somfy, Signify/Philips, Shelly, LUMI/Aqara, IKEA, frient, and Eurotronic devices.
- Captured endpoint/cluster layouts and
zha_lib_entitiesfor each added fixture to support the “round-trip diagnostics JSON == fixture JSON” test intests/test_discover.py.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/data/devices/tze20c-tjz9ad5g-ts0601-0x00000046.json | Adds a TS0601 IAS/Env-sensor-style diagnostics fixture. |
| tests/data/devices/tze204-ztc6ggyl-ts0601.json | Adds a TS0601 diagnostics fixture (quirk-applied) with entity set. |
| tests/data/devices/tze204-bvfld3xc-ts0601-0x0000004a.json | Adds a TS0601 diagnostics fixture including OTA versioned filename. |
| tests/data/devices/tz3218-ya5d6wth-ts000f-0x00000066.json | Adds a TS000F multi-endpoint light fixture with OTA version suffix. |
| tests/data/devices/tz3000-zxrfobzw-ts0002-0x00000053.json | Adds a TS0002 2-gang switch fixture with Tuya-specific clusters/entities. |
| tests/data/devices/sonoff-mini-zb1gsp-0x00001102.json | Adds a Sonoff MINI-ZB fixture including metering/electrical measurement entities. |
| tests/data/devices/somfy-ysia-variation-5c-0xffffffff.json | Adds a Somfy controller fixture (multi-endpoint + config tool endpoint). |
| tests/data/devices/signify-netherlands-b-v-rwl022-0x02005501.json | Adds a Philips/Signify RWL022 remote fixture with OTA version suffix. |
| tests/data/devices/shelly-blu-motion-zb.json | Adds a Shelly BLU Motion ZB IAS Zone fixture. |
| tests/data/devices/lumi-lumi-sensor-smoke-acn03-0x00000013.json | Adds an Aqara/LUMI smoke sensor (acn03) fixture including extra entities. |
| tests/data/devices/frient-a-s-kepzb-110-0x00020006.json | Adds a frient KEPZB-110 keypad fixture (incl. alarm control panel entity). |
| tests/data/devices/eurotronic-spzb0001-0x0162e9d2.json | Adds an Eurotronic thermostat fixture including climate/number entities. |
| tests/data/devices/aqara-lumi-switch-agl006-0x0000171b.json | Adds an Aqara switch fixture with metering/electrical measurement entities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "endpoint_id": 232, | ||
| "available": true, | ||
| "group_id": null, | ||
| "installed_version": "0xffffffff", |
There was a problem hiding this comment.
There I guess are two sources for this: the current_file_version attribute (technically this is a valid value!) and as part of a QueryNextImage command (invalid). I wonder which it is?
No description provided.