Expand LUA_FUNCTION macro and remove its definition#326
Merged
Conversation
Co-authored-by: zhaozg <542599+zhaozg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] We have a macro named
Expand LUA_FUNCTION macro and remove its definition
Sep 21, 2025
LUA_FUNCTION, #define LUA_FUNCTION(X) int X(lua_State *L)
现在将代码中的 LUA_FUNCTION 展开,并且不再使用
zhaozg
marked this pull request as ready for review
September 21, 2025 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the requirement to expand the
LUA_FUNCTIONmacro throughout the codebase and remove its definition entirely.Changes Made
The
LUA_FUNCTION(X)macro was defined as:This PR expands all 258 usages of this macro across the codebase, replacing them with explicit function declarations and definitions:
Before:
After:
Files Modified
src/openssl.hexpandedVerification
LUA_FUNCTIONreferences remain in the codebaseThe codebase now uses standard C function declarations throughout, improving code clarity and removing the dependency on the custom macro.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.