Support downstream type checking by including py.typed - #306
Merged
Conversation
maxrjones
temporarily deployed
to
test-release
November 18, 2024 17:24 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
TomNicholas
approved these changes
Nov 18, 2024
TomNicholas
left a comment
TomNicholas
left a comment
Member
There was a problem hiding this comment.
Oh good catch! This is worth a note in the release notes.
maxrjones
temporarily deployed
to
test-release
November 18, 2024 17:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://peps.python.org/pep-0561/, a package must add a marker file named
py.typedto their package to suppoer type checking of their code. I'd like to use VirtualiZarr's type checking in https://github.com/developmentseed/virtualize-nex-gddp-cmip6 and expect others would find this helpful, so this PR adds the marker file to the package.