fix switch over candidate retrieving#2760
Merged
FxKu merged 4 commits intoNov 1, 2024
Merged
Conversation
fahedouch
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
macedigital and
sdudoladov
as code owners
September 12, 2024 15:25
Signed-off-by: fahed dorgaa <fahed.dorgaa.ext@corp.ovh.com>
fahedouch
force-pushed
the
fix-asynchronous-get-switchover-candidates-upstream
branch
from
September 12, 2024 21:31
c5173e3 to
ce91e5f
Compare
|
Need this fix. I am facing the same issue |
FxKu
reviewed
Nov 1, 2024
FxKu
reviewed
Nov 1, 2024
Contributor
|
👍 |
1 similar comment
Member
|
👍 |
Contributor
|
Thanks @fahedouch for your contribution and improving the operator experience 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixe issue.
When asynchronous mode is enabled and no candidates are found, no retry is currently triggered to fetch a switchover candidate from the Patroni API. This PR enables retry for asynchronous mode, similar to synchronous mode.