Skip to content

Logical backup secret#2051

Merged
FxKu merged 7 commits into
zalando:masterfrom
stgrace:logical-backup-secret
Jan 4, 2024
Merged

Logical backup secret#2051
FxKu merged 7 commits into
zalando:masterfrom
stgrace:logical-backup-secret

Conversation

@stgrace

@stgrace stgrace commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

See #2050

@robertlandrum

Copy link
Copy Markdown

The other implementation is "probably" better. Mine is definitely simpler. I'm not sure which warrants inclusion in the next release, but can say I've deployed mine to our non-prod environments.

@FxKu FxKu added this to the 2.0 milestone Dec 14, 2022
@KlavsKlavsen

Copy link
Copy Markdown

Whats holding this back? or have 2 who can approve just not reviewed it yet?

@ashish1099

Copy link
Copy Markdown

Any update, we are waiting on this one for long

@KlavsKlavsen

Copy link
Copy Markdown

@yajo @nihaldivyam I see you both approved this.. and yet the ZAPPR status says its "pending 2 approvals - 0/2 given" ?

@ashish1099

Copy link
Copy Markdown

@yajo @nihaldivyam thank you for approving, any update on when this can be merged. ?

@yajo

yajo commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

I have no authority in this project, no idea. I see this one has conflicts though, so even maintainers won't be able to merge.

@stgrace
stgrace requested a review from hughcapet as a code owner April 11, 2023 11:07
@stgrace

stgrace commented Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

@yajo should be solved now

@FxKu

FxKu commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

@stgrace thanks for providing this feature. I will have a look. You have to fix your unit test, too? Only +1 from project maintainers count for zappr btw.

@jonathon2nd

Copy link
Copy Markdown

Looking forward to this being done 😄
Right now managing the cronjobs manually, but every so often the operator wants to update them and places invalid config, because I do not set configLogicalBackup

@nihaldivyam

Copy link
Copy Markdown

@stgrace Eagerly waiting for this to get merged !!

@KlavsKlavsen

Copy link
Copy Markdown

@FxKu thank you for adding this to a milestone - but when will it be merged? its a "small thing" - and its really annoying we have to implement our until this works properly :(

@jiuker

jiuker commented Jun 2, 2023

Copy link
Copy Markdown

@KlavsKlavsen we need this too.

@drivebyer

drivebyer commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

@idanovinda @FxKu Eagerly waiting for this to get merged too !

@stgrace

stgrace commented Jun 3, 2023

Copy link
Copy Markdown
Contributor Author

Hi everyone,
First of all sorry for the late response, I've been busy.
I've fixed the unit tests, but the e2e tests are failing for the label testing, which is not related to my PR, so not sure why that is failing and if I can fix it.

======================================================================
FAIL: test_node_affinity (test_e2e.EndToEndTestCase)
Add label to a node and update postgres cluster spec to deploy only on a node with that label

@FxKu

@ashish1099

Copy link
Copy Markdown

@FxKu can you please look in the above issues

@szechp

szechp commented Aug 2, 2023

Copy link
Copy Markdown

it would be nice if this got merged, no one wants their s3 credentials in plain text :)

@Yingrjimsch

Copy link
Copy Markdown

Eagerly waiting for this to get merged!

@FxKu

FxKu commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@idanovinda

Copy link
Copy Markdown
Collaborator

👍

@FxKu
FxKu merged commit bbba15f into zalando:master Jan 4, 2024
@FxKu

FxKu commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Thanks @stgrace for your contribution and sorry it took us so long too merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.