fix(web): make the work log compaction marker legible in every theme - #168
Merged
Conversation
incognitojam
force-pushed
the
t3code/fix-compact-icon-contrast
branch
from
August 16, 2026 11:24
93ac3e8 to
6477309
Compare
yngatech-nightly
Bot
force-pushed
the
main
branch
from
August 16, 2026 11:27
4e2683b to
0646252
Compare
incognitojam
force-pushed
the
t3code/fix-compact-icon-contrast
branch
from
August 16, 2026 11:34
6477309 to
a0432a5
Compare
The folded-turn compaction stat used the theme action color as text on the chat canvas, which is a solid-control fill and reads below 3:1 against every built-in canvas. The 70% opacity halved what little contrast was left, so the marker meant to stand out was the dimmest thing in the row. Give it full-strength foreground instead: it still outranks the muted stats it sits beside, and it stays legible in all four themes.
incognitojam
force-pushed
the
t3code/fix-compact-icon-contrast
branch
from
August 16, 2026 12:19
a0432a5 to
f209b92
Compare
incognitojam
enabled auto-merge (squash)
August 16, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compaction marker in the folded-turn work log row was tinted
text-primary/70.--primarymaps to the theme's solid-control fill — the send-button background, which pairs with--primary-foregroundon top of it — so read as text on the chat canvas it lands dimmer than the muted stats it is meant to outrank. That holds in all 10 shipped palettes; three fall below the 3:1 floor outright, and T3 Chat dark is effectively invisible at 1.59:1.The marker now takes
text-foregroundwhile its siblings staytext-muted-foreground, keeping its emphasis by being the brightest thing in the row plus its pinned position beside the chevron. That puts it between 12.4:1 and 16.7:1. Thetransition-colors/group-hoverpair went with it, since there is nothing left to transition and the row's ownhover:text-foregroundalready covers hover. The test asserted the literaltext-primary/70string; it now asserts the marker carriestext-foregroundand not a fill-role colour.Introduced in #158. Roughly nine other sites read
--primaryas text on the canvas with the same flaw — fixing that class properly needs a contrast-solved accent-text role inpackages/shared/src/themePalettes.ts, which I left alone. No before/after image: capture kept failing on this view, and the change is one colour token on a 12px glyph.Written by an agent (Claude Code, claude-opus-5).