Skip to content

Remove yiisoft/json from require-dev section of composer.json#938

Merged
Tigrov merged 3 commits into
masterfrom
remove-ext-json
Mar 14, 2025
Merged

Remove yiisoft/json from require-dev section of composer.json#938
Tigrov merged 3 commits into
masterfrom
remove-ext-json

Conversation

@Tigrov

@Tigrov Tigrov commented Mar 13, 2025

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Mar 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (e3351d5) to head (06f1fa8).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #938   +/-   ##
=========================================
  Coverage     99.23%   99.23%           
  Complexity     1538     1538           
=========================================
  Files            98       98           
  Lines          3806     3806           
=========================================
  Hits           3777     3777           
  Misses           29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov added the status:code review The pull request needs review. label Mar 13, 2025
@Tigrov
Tigrov requested a review from a team March 13, 2025 05:26

@vjik vjik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ext-json also

@Tigrov

Tigrov commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Remove ext-json also

ext-json is used by the db package

@vjik

vjik commented Mar 13, 2025

Copy link
Copy Markdown
Member

ext-json is used by the db package

As of PHP 8.0.0, the JSON extension is a core PHP extension, so it is always enabled.

@Tigrov
Tigrov requested a review from vjik March 13, 2025 20:31
@Tigrov
Tigrov merged commit b5a8f8a into master Mar 14, 2025
@Tigrov
Tigrov deleted the remove-ext-json branch March 14, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants