Skip to content

ci: enable ESM loader for Docusaurus #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 1 commit into from
Jan 31, 2022
Merged

ci: enable ESM loader for Docusaurus #4041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/e2e-docusaurus-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,20 @@ jobs:
- name: 'Running the integration test'
run: |
source scripts/e2e-setup-ci.sh

# TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed
YARN_PNP_ENABLE_ESM_LOADER=true

Comment on lines +27 to +30

@arcanis arcanis Jan 31, 2022 •
edited by merceyz
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment here has been fixed in 17.4.0 (PR), correct? Perhaps we should just upgrade the Node version here?

berry/scripts/e2e-setup-ci.sh

Lines 31 to 38 in bd146cc

# TODO: Remove when either of these issues are fixed
# - https://github.com/nodejs/node/issues/39140
# - https://github.com/nodejs/node/issues/37782
# - https://github.com/facebook/jest/issues/12060
# Due to a bug in `jest-worker` and/or Node.js adding a loader
# causes our e2e tests to time out so require the tests that needs it
# to explicitly enable it
export YARN_PNP_ENABLE_ESM_LOADER=false

@merceyz merceyz Jan 31, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you meant to link to nodejs/node#41221 then yes, it has been fixed in 17.4.0 but I don't want to upgrade the CI to that version due to the OpenSSL changes causing webpack@4 builds to not work. I'd rather wait for that PR to be backported.

yarn dlx create-docusaurus@latest my-website classic && cd my-website
yarn build

- name: 'Running the TypeScript integration test'
run: |
source scripts/e2e-setup-ci.sh

# TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed
YARN_PNP_ENABLE_ESM_LOADER=true

yarn dlx create-docusaurus@latest my-website-ts classic --typescript && cd my-website-ts
yarn build
if: |
Expand Down