Skip to content

use built in clip - #310

Merged
raybellwaves merged 2 commits into
xarray-contrib:mainfrom
raybellwaves:fix-clip
May 8, 2021
Merged

use built in clip#310
raybellwaves merged 2 commits into
xarray-contrib:mainfrom
raybellwaves:fix-clip

Conversation

@raybellwaves

Copy link
Copy Markdown
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance (if you touched existing code run asv to detect performance changes)
  • refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. This could point to a cell in the updated notebooks. Or a snippet of code with accompanying figures here.

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas
  • Tests added for pytest, if necessary.

Pre-Merge Checklist (final steps)

  • I have rebased onto main or develop (wherever I am merging) and dealt with any conflicts.
  • I have squashed commits to a reasonable amount, and force-pushed the squashed commits.

References

Please add any references to manuscripts, textbooks, etc.

@codecov

codecov Bot commented May 8, 2021

Copy link
Copy Markdown

Codecov Report

Merging #310 (54ff8f2) into main (e2e3e7f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files          23       23           
  Lines        2566     2566           
=======================================
  Hits         2425     2425           
  Misses        141      141           
Impacted Files Coverage Δ
xskillscore/core/probabilistic.py 90.94% <100.00%> (ø)
xskillscore/tests/test_probabilistic.py 96.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b47b9...54ff8f2. Read the comment docs.

@raybellwaves

Copy link
Copy Markdown
Member Author

@aaronspring if ok i'm going to merge. planning on a release when #307 goes in

@raybellwaves
raybellwaves merged commit 3e4c49d into xarray-contrib:main May 8, 2021
@raybellwaves
raybellwaves deleted the fix-clip branch May 8, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant