trigger CI - #308
Closed
raybellwaves wants to merge 5 commits into
Closed
Conversation
aaronspring
reviewed
May 7, 2021
| # xhistogram 0.1.3 introduced an error that broke xskillscore | ||
| # see https://github.com/xgcm/xhistogram/issues/48 | ||
| - xhistogram!=0.1.3 | ||
| - xhistogram==0.1.2 |
Member
Author
There was a problem hiding this comment.
yeah fails on xh==0.1.2 as well as xh latest. Guessing it's an xarray/dask/numpy update
Collaborator
There was a problem hiding this comment.
Sorry guys, still waiting on a fix from dask for xhistogram
Member
Author
There was a problem hiding this comment.
yeah no worries mate. I created an issue for it here #311
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 23 23
Lines 2566 2566
=======================================
Hits 2425 2425
Misses 141 141 Continue to review full report at Codecov.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this brings in
Pinned xhistogram to 0.1.2 (see xgcm/xhistogram#48)
Pinned xarray to 0.17.0 (xarray released yesterday on http://xarray.pydata.org/en/stable/whats-new.html#v0-18-0-6-may-2021)
@aaronspring how's climpred?
Pinning xarray fixed it. Will have to find a minimal example.