autocorrelation?

[ahuang11]

Is it appropriate to have auto correlation in xskillscore? My thought is yes, since there's a brier_score and brier_score_threshold?
def pearson_r_autocorrelation(a, lag=...)?

[aaronspring]

I dont see the link between brier_score and autocorr.

What about adding the lag=0 keyword to all functions? you could also have a lagged correlation between two fields, autocorr then becomes function(a,a,lag=1). probably easy implementable with a wrapper.

[bradyrx]

Agreed. Lagged correlations are very useful in our field of course. See corr under https://github.com/bradyrx/esmtools/blob/master/esmtools/stats.py for implementation. Just need to be careful here with docstring so it's clear which direction lag=N shifts a and b.

[raybellwaves]

closing in favor of #284