Node types are pulled accidentally by importing vite types

[minht11]

Describe the bug

See the same issue in different package Anber/wyw-in-js#33

I was investigating why node types are included in my project and came to cause being .wxt/types/imports.d.ts file, which imports for example:
const ContentScriptContext: typeof import('wxt/client')['ContentScriptContext']

And that file uses:

import { ContentScriptDefinition } from '../../types'

Which in turn imports:
import type * as vite from 'vite';

If we look at vite, it uses <reference types="node" /> which means any file importing it also gets the same types.

The fix would be split vite types from client ones, so two are not mixed.

Reproduction

n/a

Steps to reproduce

Try using const timeout: number = setTimeout(() => {})

System Info

"wxt": "^0.19.27"

Used Package Manager

pnpm

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[aklinker1]

This was intended, but I can see why it would cause problems. Will try to fix post-v1.0!

[garretwilson]

I just ran into this in a background script, which has no window object but still supports setTimeout() and the like. The following puts the error checker into a frenzy, because apparently it thinks this is the Node setTimeout() method, returning a Timeout:

let timeoutId: number | null;
timeoutId = setTimeout(() => foo.bar(), 60*1000);

The work around is as any as number, like the old Java cast (NoReallyMyOtherType)(Object)foo (like the even old older C/C++ reference/dereference trick—so long ago I've forgotten how it works):

timeoutId = setTimeout(() => foo.bar(), 60*1000) as any as number;

P.S. It turns out it's not a good idea to use timeouts in background scripts in MV3 as they don't work across background script restarts, so this particular example is moot now with my use case.