Fix the design mode issues - #3050
Conversation
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughChangesDesign mode
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Operator
participant API Portal
participant configLoader
participant dbDriver
participant Handlebars
Operator->>API Portal: Enable design mode and restart
API Portal->>configLoader: Load design-mode configuration
configLoader-->>API Portal: Provide session secret
API Portal->>dbDriver: Request database adapter
dbDriver-->>API Portal: Return design-mode stub
API Portal->>Handlebars: Render portal pages
Handlebars-->>Operator: Show preview with unavailable links disabled
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@portals/api-portal/distribution/README.md`:
- Line 120: Update the design-mode preview URL in the README text to use HTTPS
instead of HTTP, changing it to https://localhost:9543/views/default while
preserving the surrounding explanation.
- Line 118: Update the restart command in the API Portal README to use the
Compose service name devportal instead of the container name api-portal, while
keeping the docker compose up command unchanged.
In `@portals/api-portal/src/config/configLoader.js`:
- Around line 369-385: Update the designMode-enabled branch in the config
loading flow to generate an ephemeral sessionSecret only when it is absent, then
validate any resulting or operator-supplied value with requireHexSecret.
Preserve the existing encryptionKey validation for non-design mode and ensure
supplied design-mode secrets cannot bypass validation.
In `@portals/api-portal/src/pages/applications/partials/applications-listing.hbs`:
- Around line 38-40: Update the application listing controls and their handlers
to honor designMode, not only the card navigation in the app-card markup. Hide
or disable Create and Delete actions and prevent their /applications mutation
handlers from executing when designMode is enabled, while preserving existing
behavior outside design mode.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c774a5c-583a-4070-856f-0a8a54da0c5f
📒 Files selected for processing (18)
portals/api-portal/.dockerignoreportals/api-portal/Makefileportals/api-portal/README.mdportals/api-portal/configs/config-template.tomlportals/api-portal/distribution/README.mdportals/api-portal/docker-compose.yamlportals/api-portal/docs/administer/asgardeo-setup.mdportals/api-portal/docs/administer/authentication.mdportals/api-portal/src/config/configLoader.jsportals/api-portal/src/db/driver.jsportals/api-portal/src/defaultContent/pages/api-landing/partials/api-subscription-plans.hbsportals/api-portal/src/defaultContent/pages/mcp-landing/partials/mcp-subscription-plans.hbsportals/api-portal/src/defaultContent/partials/header.hbsportals/api-portal/src/defaultContent/partials/sidebar.hbsportals/api-portal/src/defaultContent/styles/components.cssportals/api-portal/src/helpers/handlebarsHelpers.jsportals/api-portal/src/pages/applications/partials/applications-listing.hbsportals/api-portal/src/server.js
Purpose
$subject
Summary
Fix the broken design mode
Also Added a volume mount for the samples
Approach
TBD
Also fixed the coderabbit comments of #3045