[Devportal] Support repeatable --config flag - #3002
Conversation
📝 WalkthroughWalkthroughThe Developer Portal now requires explicit ChangesDeveloper Portal configuration loading
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@portals/developer-portal/src/config/configLoader.js`:
- Around line 66-69: Update the configuration-loading function around
snakeToCamelDeep and the final return of merged to reject an empty merged portal
configuration after all layering is complete. Check whether merged has any own
keys, and fail fast before returning it when none exist, while preserving the
existing merged result for non-empty configurations.
In `@portals/developer-portal/src/config/configMerge.js`:
- Around line 39-46: Update snakeToCamelDeep so Date instances are returned
unchanged before the generic object-recursion branch. Preserve the existing
recursive conversion for ordinary tables and nested objects.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7d1a486c-f152-43bb-8436-5031073efdd8
📒 Files selected for processing (7)
portals/developer-portal/configs/config-template.tomlportals/developer-portal/configs/config.tomlportals/developer-portal/docker-entrypoint.shportals/developer-portal/package.jsonportals/developer-portal/src/config/configLoader.jsportals/developer-portal/src/config/configMerge.jsportals/developer-portal/src/config/configMerge.test.js
Purpose
Fix #2876
Summary