-
Notifications
You must be signed in to change notification settings - Fork 0
Tooltips UI fixes, refine descriptive text, add talents + constellations rating functionality + main UI in characters page #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
63d8b52
cons + talents
woopxwoop 5608b5a
remove tooltips for now
woopxwoop e0470fe
tooltips fixed and certain descriptive text made more human understan…
woopxwoop 33a55db
Merge branch 'UI' into talents
woopxwoop 11ec5e6
use median
woopxwoop a95334c
Merge branch 'main' of https://github.com/woopxwoop/lightkeepers-fron…
woopxwoop 250a793
cr
woopxwoop 716ec3b
Δ / vs-base cells sit outside the config link; negPctTip is a focusab…
woopxwoop 30f1be1
text label consistency
woopxwoop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /** | ||
| * Qualitative upgrade tiers from a median % DPS impact | ||
| * (gain for cons/sig, drop for talent/level). | ||
| * | ||
| * Each Builds section passes its own cutoffs + labels via | ||
| * {@link UpgradeImpactConfig}. | ||
| */ | ||
|
|
||
| export type UpgradeTier = | ||
| | "highly_recommended" | ||
| | "recommended" | ||
| | "inconsequential"; | ||
|
|
||
| export interface UpgradeImpactConfig { | ||
| /** |median %| ≥ this → highly_recommended */ | ||
| highPct: number; | ||
| /** |median %| ≥ this → recommended (else inconsequential) */ | ||
| recommendedPct: number; | ||
| labels: Record<UpgradeTier, string>; | ||
| } | ||
|
|
||
| export interface UpgradeImpact { | ||
| tier: UpgradeTier; | ||
| label: string; | ||
| } | ||
|
|
||
| /** Default upgrade wording (talents / cons / signature). */ | ||
| export const DEFAULT_UPGRADE_LABELS: Record<UpgradeTier, string> = { | ||
| highly_recommended: "Highly recommended to upgrade", | ||
| recommended: "Recommended to upgrade", | ||
| inconsequential: "Largely inconsequential", | ||
| }; | ||
|
|
||
| export const TALENT_UPGRADE: UpgradeImpactConfig = { | ||
| highPct: 10, | ||
| recommendedPct: 4, | ||
| labels: DEFAULT_UPGRADE_LABELS, | ||
| }; | ||
|
|
||
| export const CONSTELLATION_UPGRADE: UpgradeImpactConfig = { | ||
| highPct: 20, | ||
| recommendedPct: 8, | ||
| labels: { | ||
| highly_recommended: "High impact constellation", | ||
| recommended: "Mid impact constellation", | ||
| inconsequential: "Low impact constellation", | ||
| }, | ||
| }; | ||
|
|
||
| export const SIGNATURE_UPGRADE: UpgradeImpactConfig = { | ||
| highPct: 20, | ||
| recommendedPct: 8, | ||
| labels: { | ||
| highly_recommended: "High impact weapon", | ||
| recommended: "Mid impact weapon", | ||
| inconsequential: "Low impact weapon", | ||
| }, | ||
| }; | ||
|
|
||
| export const LEVEL_UPGRADE: UpgradeImpactConfig = { | ||
| highPct: 5, | ||
| recommendedPct: 2, | ||
| labels: { | ||
| highly_recommended: "Highly recommended to level to 90", | ||
| recommended: "Recommended to level to 90", | ||
| inconsequential: "Leveling to 90 is inconsequential", | ||
| }, | ||
| }; | ||
|
|
||
| /** Classify |pct| into a tier + label using section-specific cutoffs. */ | ||
| export function classifyUpgradeImpact( | ||
| pct: number, | ||
| config: UpgradeImpactConfig, | ||
| ): UpgradeImpact { | ||
| const abs = Math.abs(pct); | ||
| const tier: UpgradeTier = | ||
| abs >= config.highPct | ||
| ? "highly_recommended" | ||
| : abs >= config.recommendedPct | ||
| ? "recommended" | ||
| : "inconsequential"; | ||
| return { tier, label: config.labels[tier] }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.