Dtls multi core#414
Merged
Merged
Conversation
JacobBarthelmeh
force-pushed
the
DTLS-MultiCore
branch
from
5ff4841 to
79464bf
Compare
JacobBarthelmeh
force-pushed
the
DTLS-MultiCore
branch
from
57cb3cc to
8d66ba2
Compare
JacobBarthelmeh
force-pushed
the
DTLS-MultiCore
branch
from
ba7549e to
c857656
Compare
Contributor
Author
|
Made the changes talked about in code review. |
Contributor
|
On Mac I get some unused function errors on basic ./configure and ./configure --enable-dtls src/internal.c:361:20: error: unused function 'c64toa' |
| WOLFSSL_API int wolfSSL_CTX_dtls_set_export(WOLFSSL_CTX* ctx, | ||
| wc_dtls_export func); | ||
| WOLFSSL_API int wolfSSL_dtls_set_export(WOLFSSL* ssl, wc_dtls_export func); | ||
| WOLFSSL_API int wolfSSL_dtls_export(unsigned char* buf, unsigned int* sz, |
Contributor
There was a problem hiding this comment.
I think having WOLFSSL parameter first is more consistent.
Contributor
Author
|
Thanks for the review of the code Todd. Will fix the unused functions, it slipped by from using GCC during development. |
Contributor
|
Thanks for the changes, looks good! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to use --enable-sessionexport with DTLS and send a session after completing change cipher spec in handshake.