Skip to content

embOS port#407

Merged
toddouska merged 6 commits into
masterfrom
embOS-port
May 5, 2016
Merged

embOS port#407
toddouska merged 6 commits into
masterfrom
embOS-port

Conversation

@kaleb-himes

@kaleb-himes kaleb-himes commented May 3, 2016

Copy link
Copy Markdown
Contributor

Ready for review

@kaleb-himes
wolfSSL embOS port Initialize
d184f8b 
self-review complete

Removed autogenerated files
dgarske
dgarske reviewed May 4, 2016
View reviewed changes
Comment thread IDE/IAR-EWARM/embOS/SAMV71_XULT/embOS_SAMV71_XULT_user_settings/user_settings_verbose_example.h Outdated
/* ------------------------------------------------------------------------- */
// See README.md for instructions
//#define FREESCALE_MMCAU 1

@dgarske dgarske May 4, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent version of the user_settings.h that I've been working with is here:
https://github.com/dgarske/wolfssl/blob/mathfixes/IDE/ROWLEY-CROSSWORKS-ARM/user_settings.h

I'd recommend removing the "HW Crypto Acceleration" section. Also the new version has a section for Ed/Curve25519 and also has a few typo fixes (such as GCM_SMALL comment). Also maybe you should remove TFM_CHECK and WOLFSSL_DEBUG_MATH.

@dgarske

dgarske commented May 4, 2016

Copy link
Copy Markdown
Member

Please review my feedback. Mainly I believe you can eliminate the settings folders and the .dep files. Also the USE_FAST_MATH should be in the user_settings.h file, not in settings.h. Thanks!

@dgarske dgarske assigned kaleb-himes and unassigned dgarske May 4, 2016
@dgarske

dgarske commented May 4, 2016

Copy link
Copy Markdown
Member

Looks good to me. Ready for final review / approval by @toddouska.

@kaleb-himes
Make suggested changes from first review
ca2f0af 
Add changes to the example user settings noted by david

missed .dep files, exclude these as well

.dep files are necessary

rebase
@kaleb-himes

kaleb-himes commented May 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Steps taken:

Cleanup as many files as possible
Simplify the custom_port with a readme and file system
Remove Track Memory
Verified is added to distribution (All of IDE/IAR-EWARM is added)
Create distribution and test it myself
Create a new clean distribution and have Jacob Test it
Made suggested changes from David's Review

Changed version to 3.9.1 see PR #410

@kaleb-himes kaleb-himes mentioned this pull request May 4, 2016
Merged
@dgarske dgarske assigned toddouska and unassigned kaleb-himes May 5, 2016
@toddouska

toddouska commented May 5, 2016

Copy link
Copy Markdown
Contributor

My only suggestion is to have a clear explanation in the IDE/IAR-EWARM/README about when to use the embOS folder and when to use Projects folder. Right now, the REAMDE makes no mention of of embOS. I think this will avoid some confusion for new wolfSSL users with IAR.

@kaleb-himes

kaleb-himes commented May 5, 2016

Copy link
Copy Markdown
Contributor Author

Readme update in IDE/IAR-EWARM noting the embOS directory and it's intended use.

Distribution test re-run by Jacob Barthelmeh

@toddouska

toddouska commented May 5, 2016

Copy link
Copy Markdown
Contributor

Thanks for the changes.

@toddouska toddouska merged commit ee21d33 into master May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@toddouska toddouska

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaleb-himes @dgarske @toddouska