Skip to content

internal.c: extract functions to make code cleaner#10841

Open
SparkiDev wants to merge 1 commit into
wolfSSL:masterfrom
SparkiDev:extract_funcs_ssl_1
Open

internal.c: extract functions to make code cleaner#10841
SparkiDev wants to merge 1 commit into
wolfSSL:masterfrom
SparkiDev:extract_funcs_ssl_1

Conversation

@SparkiDev

Copy link
Copy Markdown
Contributor

Description

Extracted to functions pieces of code from very long functions.

Testing

enable-all

@SparkiDev SparkiDev self-assigned this Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m3

  • FLASH: .text +32 B (+0.0%, 122,213 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +192 B, .text +64 B (+0.0%, 769,748 B / 1,048,576 B, total: 73% used)

gcc-arm-cortex-m4-pq

  • FLASH: .text +64 B (+0.0%, 279,048 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .text +64 B (+0.0%, 324,648 B / 1,048,576 B, total: 31% used)

gcc-arm-cortex-m7

  • FLASH: .text +64 B (+0.0%, 199,902 B / 262,144 B, total: 76% used)

gcc-arm-cortex-m7-pq

  • FLASH: .text +64 B (+0.0%, 279,624 B / 1,048,576 B, total: 27% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .text +64 B (+0.0%, 235,792 B / 262,144 B, total: 90% used)

linuxkm-standard

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10841

Scan targets checked: wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/internal.c Outdated
@SparkiDev SparkiDev force-pushed the extract_funcs_ssl_1 branch from d47fff1 to bebac71 Compare July 3, 2026 06:28
@SparkiDev SparkiDev force-pushed the extract_funcs_ssl_1 branch from bebac71 to 9138119 Compare July 3, 2026 10:15
@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Jul 3, 2026
@SparkiDev SparkiDev requested a review from wolfSSL-Bot July 3, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants