client/server-only builds + relocate examples#122
Merged
Conversation
bigbrett
requested review from
billphipps and
Copilot
and removed request for
Copilot
June 16, 2025 21:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces build macros to support client‐only and server‐only builds and relocates example files. Key changes include:
- Adding client/server enable macros and a client‐only TCP test build option.
- Integrating GitHub Actions workflows for testing the updated configuration.
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/demo/client/wh_demo_client_keystore.h | New client keystore header with API declarations. |
| examples/demo/client/wh_demo_client_keystore.c | Implements keystore functions including caching, committing, and eviction logic. |
| examples/demo/client/wh_demo_client_crypto.h | Declares crypto demo functions supporting various algorithms. |
| examples/demo/client/wh_demo_client_counter.h & .c | Adds a minimal counter demo. |
| examples/demo/client/wh_demo_client_all.h & .c | Aggregates all client demo functions. |
| examples/demo/certs/* | Adds demo certificate and key files for RSA, ECC, and Curve25519. |
| examples/demo/certs/genKeys.sh | Provides a script for generating keys with a TODO regarding Curve25519 keys. |
| examples/README.md | Updates documentation for example usage and build instructions. |
| benchmark/config/wolfhsm_cfg.h | Adds macros to enable both client and server functionality. |
| .github/workflows/* | Introduces and updates GitHub Actions workflows for various build configurations. |
Comments suppressed due to low confidence (2)
examples/README.md:3
- Typo found: 'aformentioned' should be corrected to 'aforementioned'.
This directory contains examples code demonstrating how to use various wolfHSM features. The examples provided are split between port-agnostic demo code, and port-specific server/client applications that use the aformentioned demo code.
examples/demo/client/wh_demo_client_keystore.c:212
- Consider using a defined error constant instead of returning -1 directly, to maintain consistency with other wolfHSM error codes.
return -1;
billphipps
previously approved these changes
Jun 20, 2025
billphipps
left a comment
Contributor
There was a problem hiding this comment.
Loving the explicit server/client build options! Awesome that we can get all the examples in here now and simplify repo management!
Looks really good. I had a few comments and questions but I think it can go in without any changes if you don't agree with my comments
Contributor
Author
|
Fixed all changes, CI will fail until #123 merges |
billphipps
previously approved these changes
Jun 23, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bigbrett
force-pushed
the
client-server-enable-macros
branch
from
June 23, 2025 14:33
f2aeaf0 to
4f1c2db
Compare
billphipps
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.