fix: bound retained derived reads - #657
Merged
Merged
Conversation
Carry large support sets through a connection-local SQLite TEMP table instead of expanding one bind variable per selected event. Preserve removal-before-signature closure and document the ordering and immutability invariants at retained scale.
Write and sync progress metadata under an ignored temporary name before exposing the final JSON publication marker. Prevent concurrent Inspector status reads from classifying a partially written progress row as corrupt derived state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
just check(3,151 passed; 5 skipped)/api/revisionsexercise on a 102,400-event storeKnown performance characteristic
The unfiltered revisions route is now correct at retained scale, but it still hydrates historical events individually and remains expensive. This change deliberately fixes correctness and publication safety without changing response semantics.