Escape source and enclosure fields in RSS feed generation - #17209
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7177359 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
marked this pull request as ready for review
June 26, 2026 14:06
delucis
approved these changes
Jun 26, 2026
delucis
left a comment
delucis
left a comment
Member
There was a problem hiding this comment.
LGTM!
Noting there’s no linked issue in case there was supposed to be one this closes?
Contributor
Author
|
Yeah, this is something I found outside of an issue. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sourceandenclosureitem elements as structured XML objects instead of interpolating values into a string and re-parsing them. This ensures special characters in fields likesource.titleandenclosure.typeare always serialized as text, consistent with how every other feed field is already handled.Testing
sourceandenclosurefields containing XML special characters, asserting the values round-trip verbatim and produce exactly one element each.Docs