Fix hosted SDK native architecture validation - #140
Open
wiresock wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the “Hosted WireSock SDK experiment” to run only on native x64 and ARM64 GitHub-hosted runners, and switches SDK acquisition from WinGet bootstrapping to direct downloads of the audited installer artifacts, while keeping the existing trust/verification checks aligned with the hardened workflow-security gates.
Changes:
- Restricts hosted SDK lifecycle validation to x64 and ARM64 (drops x86 from the hosted experiment matrix).
- Updates the hosted experiment script to download audited SDK installer artifacts directly (removing WinGet bootstrap dependency) and keeps SHA-256 + Authenticode verification.
- Refreshes workflow-security production digests and documentation to match the new hosted experiment behavior and rationale.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/Test-WorkflowSecurity.ps1 | Updates production workflow digest and required hosted SDK matrix lines to match the new x64/ARM64-only workflow. |
| scripts/Invoke-HostedSdkExperiment.ps1 | Removes x86 support, removes WinGet bootstrap, and downloads/validates audited SDK installer artifacts directly for x64/ARM64. |
| README.md | Documents why hosted validation is x64/ARM64-only and why x86 SDK lifecycle validation needs a native 32-bit/self-hosted environment. |
| .github/workflows/hosted-sdk-experiment.yml | Updates the hosted experiment workflow matrix and logging to run only x64 and ARM64. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failure analysis
Validation