Skip to content

ci: isolate hosted SDK cleanup exit code - #138

Merged
wiresock merged 1 commit into
mainfrom
codex/hosted-sdk-cleanup-exit-code
Aug 12, 2026
Merged

ci: isolate hosted SDK cleanup exit code#138
wiresock merged 1 commit into
mainfrom
codex/hosted-sdk-cleanup-exit-code

Conversation

@wiresock

Copy link
Copy Markdown
Owner

Summary

  • run best-effort hosted SDK package removal through Start-Process
  • inspect the cleanup process's own exit code instead of leaking it through PowerShell's $LASTEXITCODE
  • preserve the warning when WinGet cannot find an uninstall registration on the disposable VM

Why

Hosted run https://github.com/wiresock/WireSockUI/actions/runs/31591854488 passed SDK installation, signature validation, WireSockUI MSI install/repair/uninstall, and all Transparent, VirtualAdapter, Kill Switch, and Amnezia lifecycle checks. The step was marked failed only after WinGet returned "No installed package found" during best-effort cleanup and left its exit code as the script's final native exit code.

Validation

  • PowerShell parser validation passed
  • isolated nonzero child-process probe confirmed Start-Process preserves the preceding $LASTEXITCODE
  • workflow security fixtures passed
  • production workflow contracts passed
  • git diff --check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the hosted SDK experiment cleanup logic to prevent best-effort WinGet uninstall failures from incorrectly propagating as the PowerShell script’s final exit code in GitHub Actions.

Changes:

  • Run WinGet uninstall via Start-Process -Wait -PassThru and inspect the spawned process’s ExitCode.
  • Avoid relying on (and inadvertently leaking) PowerShell’s $LASTEXITCODE during best-effort cleanup, while still warning on nonzero uninstall results.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wiresock
wiresock merged commit 1e66ad6 into main Aug 12, 2026
24 checks passed
@wiresock
wiresock deleted the codex/hosted-sdk-cleanup-exit-code branch August 12, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants