ci: isolate hosted SDK cleanup exit code - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the hosted SDK experiment cleanup logic to prevent best-effort WinGet uninstall failures from incorrectly propagating as the PowerShell script’s final exit code in GitHub Actions.
Changes:
- Run WinGet uninstall via
Start-Process -Wait -PassThruand inspect the spawned process’sExitCode. - Avoid relying on (and inadvertently leaking) PowerShell’s
$LASTEXITCODEduring best-effort cleanup, while still warning on nonzero uninstall results.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start-Process$LASTEXITCODEWhy
Hosted run https://github.com/wiresock/WireSockUI/actions/runs/31591854488 passed SDK installation, signature validation, WireSockUI MSI install/repair/uninstall, and all Transparent, VirtualAdapter, Kill Switch, and Amnezia lifecycle checks. The step was marked failed only after WinGet returned "No installed package found" during best-effort cleanup and left its exit code as the script's final native exit code.
Validation
Start-Processpreserves the preceding$LASTEXITCODEgit diff --checkpassed