ci: distinguish synthetic SDK lifecycle - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a distinct “synthetic” SDK lifecycle mode intended for the GitHub-hosted TEST-NET experiment, so hosted runs can validate the real SDK lifecycle/cleanup behavior without requiring an externally connected tunnel, while keeping the protected “real profile” SDK integration mode strict about tunnel active/connected state.
Changes:
- Added a new
--sdk-synthetic-integrationswitch to the test runner and made--sdk-integrationand--sdk-synthetic-integrationmutually exclusive. - Plumbed a
requireActiveTunnelflag through the SDK smoke path so synthetic mode permitsGetTunnelActive == false(but still treats native query errors and cleanup failures as fatal). - Updated the hosted experiment script and README wording to reflect the synthetic connectivity boundary.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WireSockUI.Tests/Program.cs | Adds a synthetic SDK integration mode, adjusts smoke assertions to allow inactive tunnels when requested, and adds a targeted fake-API regression test. |
| scripts/Invoke-HostedSdkExperiment.ps1 | Switches the hosted experiment to call the new synthetic SDK integration mode and updates the step summary text accordingly. |
| README.md | Documents the hosted experiment’s synthetic lifecycle scope and explicitly distinguishes it from the strict self-hosted connected integration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Hosted run https://github.com/wiresock/WireSockUI/actions/runs/31588766251 proved that the disposable Windows runner can install the audited WireSock SDK, build and install the WireSockUI MSI, and create/start/query/stop/drop an SDK tunnel. It failed only because the synthetic profile intentionally points at an unreachable IANA TEST-NET endpoint, so it cannot honestly assert a connected tunnel.
Validation
git diff --checkpassed